CVE-2024-57946

virtio-blk: don't keep queue frozen during system suspend

Medium · published January 21, 2025

CVSS v3.1
5.5
EPSS
0%
Percentile
5.6
In the wild
Unconfirmed
What it is

In the Linux kernel, the following vulnerability has been resolved:

virtio-blk: don't keep queue frozen during system suspend

Commit 4ce6e2db00de ("virtio-blk: Ensure no requests in virtqueues before

deleting vqs.") replaces queue quiesce with queue freeze in virtio-blk's

PM callbacks. And the motivation is to drain inflight IOs before suspending.

block layer's queue freeze looks very handy, but it is also easy to cause

deadlock, such as, any attempt to call into bio_queue_enter() may run into

deadlock if the queue is frozen in current context. There are all kinds

of ->suspend() called in suspend context, so keeping queue frozen in the

whole suspend context isn't one good idea. And Marek reported lockdep

warning[1] caused by virtio-blk's freeze queue in virtblk_freeze().

[1] https://lore.kernel.org/linux-block/[email protected]/

Given the motivation is to drain in-flight IOs, it can be done by calling

freeze & unfreeze, meantime restore to previous behavior by keeping queue

quiesced during suspend.

The record
Technical detail
CVSS v3.1
5.5 · MEDIUM
Vector
CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H
CVSS v4.0
Not supplied
EPSS
0.00167 · 5.6th percentile
Published
2025-01-21T12:22Z
EPSS history
Timeline
  • 21 JAN 12:22Z
    virtio-blk: don't keep queue frozen during system suspend
    cvelistv5