High · published November 8, 2024
In the Linux kernel, the following vulnerability has been resolved:
posix-clock: Fix missing timespec64 check in pc_clock_settime()
As Andrew pointed out, it will make sense that the PTP core
checked timespec64 struct's tv_sec and tv_nsec range before calling
ptp->info->settime64().
As the man manual of clock_settime() said, if tp.tv_sec is negative or
tp.tv_nsec is outside the range [0..999,999,999], it should return EINVAL,
which include dynamic clocks which handles PTP clock, and the condition is
consistent with timespec64_valid(). As Thomas suggested, timespec64_valid()
only check the timespec is valid, but not ensure that the time is
in a valid range, so check it ahead using timespec64_valid_strict()
in pc_clock_settime() and return -EINVAL if not valid.
There are some drivers that use tp->tv_sec and tp->tv_nsec directly to
write registers without validity checks and assume that the higher layer
has checked it, which is dangerous and will benefit from this, such as
hclge_ptp_settime(), igb_ptp_settime_i210(), _rcar_gen4_ptp_settime(),
and some drivers can remove the checks of itself.
| Product | Versions | Fixed in |
|---|---|---|
| linux/linux_kernel | ≥ 2.6.39, < 4.19.323 | 4.19.323 |
| linux/linux_kernel | ≥ 4.20, < 5.4.285 | 5.4.285 |
| linux/linux_kernel | ≥ 5.5, < 5.10.228 | 5.10.228 |
| linux/linux_kernel | ≥ 5.11, < 5.15.169 | 5.15.169 |
| linux/linux_kernel | ≥ 5.16, < 6.1.114 | 6.1.114 |
| linux/linux_kernel | ≥ 6.2, < 6.6.58 | 6.6.58 |
| linux/linux_kernel | ≥ 6.7, < 6.11.5 | 6.11.5 |
| linux/linux_kernel | all versions | — |
| linux/linux_kernel | all versions | — |
| linux/linux_kernel | all versions | — |