CVE-2024-38616

wifi: carl9170: re-fix fortified-memset warning

High · published June 19, 2024

CVSS v3.1
8.2
EPSS
1%
Percentile
50.6
In the wild
Unconfirmed
What it is

In the Linux kernel, the following vulnerability has been resolved:

wifi: carl9170: re-fix fortified-memset warning

The carl9170_tx_release() function sometimes triggers a fortified-memset

warning in my randconfig builds:

In file included from include/linux/string.h:254,

from drivers/net/wireless/ath/carl9170/tx.c:40:

In function 'fortify_memset_chk',

inlined from 'carl9170_tx_release' at drivers/net/wireless/ath/carl9170/tx.c:283:2,

inlined from 'kref_put' at include/linux/kref.h:65:3,

inlined from 'carl9170_tx_put_skb' at drivers/net/wireless/ath/carl9170/tx.c:342:9:

include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]

493 | __write_overflow_field(p_size_field, size);

Kees previously tried to avoid this by using memset_after(), but it seems

this does not fully address the problem. I noticed that the memset_after()

here is done on a different part of the union (status) than the original

cast was from (rate_driver_data), which may confuse the compiler.

Unfortunately, the memset_after() trick does not work on driver_rates[]

because that is part of an anonymous struct, and I could not get

struct_group() to do this either. Using two separate memset() calls

on the two members does address the warning though.

The record
Technical detail
CVSS v3.1
8.2 · HIGH
Vector
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:H
CVSS v4.0
Not supplied
EPSS
0.00651 · 50.6th percentile
Published
2024-06-19T13:56Z
EPSS history
Timeline
  • 19 JUN 13:56Z
    wifi: carl9170: re-fix fortified-memset warning
    cvelistv5